Notification Service #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most ground work has been covered
Added unit test for registering with an Uri as input
Codecov Report
@@ Coverage Diff @@
## develop #37 +/- ##
===========================================
+ Coverage 93.47% 93.66% +0.18%
===========================================
Files 113 116 +3
Lines 2023 2083 +60
Branches 132 133 +1
===========================================
+ Hits 1891 1951 +60
Misses 99 99
Partials 33 33 |
Fixed CA not propagating `CancellationToken` in `BaseObjectStringReader`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the notification service of the PVOutput api. It allows for registerering and deregistering notification url's that get called when certain alerts get triggered.
Closes #14, Closes #15